-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: raise error if inserting rows with unknown fields #163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm missing something here. The user controls whether they want this behavior in tabledata.insertall via ignoreUnknownValues, which is present in the insert_rows_json() method signature, but I don't see how that's plumbed to this helper.
@shollyman Hmm, good point. I'll check how the helper can support the |
Changed the helper to include missing fields and let the backend handle that. The |
Just the coverage failure it seems, will cover the missed code path. |
Assuming that the Python3 test failures in |
Indeed, and those tests were updated in https://github.com/googleapis/python-bigquery/pull/192/files |
Fixes #151.
This PR makes sure that unknown fields are not silently ignored when inserting rows, but instead such errors are detected and raised loudly.
PR checklist