Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support authorized dataset entity #1075

Merged
merged 10 commits into from
Dec 14, 2021

Conversation

steffnay
Copy link
Contributor

@steffnay steffnay commented Nov 30, 2021

Removes the client-side validation of entity types and replaces them with enum values.

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1064 🦕

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 30, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2021
@steffnay steffnay marked this pull request as ready for review November 30, 2021 22:04
@steffnay steffnay requested a review from a team November 30, 2021 22:04
@steffnay steffnay requested a review from a team as a code owner November 30, 2021 22:04
google/cloud/bigquery/enums.py Outdated Show resolved Hide resolved
tests/unit/test_dataset.py Show resolved Hide resolved
google/cloud/bigquery/dataset.py Show resolved Hide resolved
@tswast
Copy link
Contributor

tswast commented Dec 6, 2021

Let's make sure we update the code samples with the new enum too.

bigquery.AccessEntry("READER", "groupByEmail", analyst_group_email)

entity_type = "groupByEmail"

@steffnay steffnay requested a review from a team as a code owner December 6, 2021 23:46
@steffnay steffnay requested a review from tswast December 7, 2021 18:58
tests/unit/test_dataset.py Show resolved Hide resolved
@steffnay steffnay requested a review from tswast December 13, 2021 23:31
@tswast tswast merged commit c098cd0 into googleapis:main Dec 14, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 13, 2022
🤖 I have created a release *beep* *boop*
---


## [2.32.0](v2.31.0...v2.32.0) (2022-01-12)


### Features

* support authorized dataset entity ([#1075](#1075)) ([c098cd0](c098cd0))


### Bug Fixes

* remove query text from exception message, use `exception.debug_message` instead ([#1105](#1105)) ([e23114c](e23114c))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
* feat: support authorized dataset entity

* cleanup

* add test and cache the resource from from_api_repr in a _properties value

* lint

* update samples to use enums

* update to_api_repr and add tests

* refactor
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
🤖 I have created a release *beep* *boop*
---


## [2.32.0](googleapis/python-bigquery@v2.31.0...v2.32.0) (2022-01-12)


### Features

* support authorized dataset entity ([googleapis#1075](googleapis#1075)) ([c098cd0](googleapis@c098cd0))


### Bug Fixes

* remove query text from exception message, use `exception.debug_message` instead ([googleapis#1105](googleapis#1105)) ([e23114c](googleapis@e23114c))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Authorized Dataset
2 participants