Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: table schema change error #692

Merged
merged 2 commits into from
Nov 1, 2023
Merged

fix: table schema change error #692

merged 2 commits into from
Nov 1, 2023

Conversation

Linchin
Copy link
Contributor

@Linchin Linchin commented Oct 31, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #670 🦕

@Linchin Linchin requested review from a team as code owners October 31, 2023 21:29
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-pandas API. labels Oct 31, 2023
@Linchin Linchin removed the request for review from nayaknishant October 31, 2023 21:33
@Linchin Linchin added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 31, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 31, 2023
shollyman
shollyman approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you expand on the PR description to be better summarize the change before submission?

tests/unit/test_gbq.py Outdated Show resolved Hide resolved
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 1, 2023
@Linchin Linchin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2023
@Linchin Linchin added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 1, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 1, 2023
@Linchin Linchin merged commit 3dc8ebe into googleapis:main Nov 1, 2023
23 checks passed
@Linchin Linchin deleted the table-schema branch November 1, 2023 18:18
@release-please release-please bot mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

attempting to change existing datatype on BQ table through table_schema and if_exists="replace" fails
3 participants
@Linchin @shollyman @yoshi-kokoro