Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ml.metrics.mean_squared_error #559

Merged
merged 4 commits into from
Apr 3, 2024
Merged

feat: add ml.metrics.mean_squared_error #559

merged 4 commits into from
Apr 3, 2024

Conversation

GarrettWu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@GarrettWu GarrettWu requested review from shobsi and ashleyxuu April 1, 2024 22:22
@GarrettWu GarrettWu requested review from a team as code owners April 1, 2024 22:22
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Apr 1, 2024
ashleyxuu
ashleyxuu reviewed Apr 2, 2024
View reviewed changes
third_party/bigframes_vendored/sklearn/metrics/_regression.py Outdated
Estimated target values.

Returns:
float: Mean squared error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing "."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@GarrettWu GarrettWu requested a review from ashleyxuu April 2, 2024 17:38
@GarrettWu GarrettWu merged commit 853c25e into main Apr 3, 2024
16 checks passed
@GarrettWu GarrettWu deleted the garrettwu-mse branch April 3, 2024 17:33
@release-please release-please bot mentioned this pull request Apr 3, 2024
Merged
Genesis929 pushed a commit that referenced this pull request Apr 9, 2024
@GarrettWu @Genesis929
feat: add ml.metrics.mean_squared_error (#559)
2c80c9d 
* feat: add ml.metrics.mean_squared_error

* fix docs

* fix docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleyxuu ashleyxuu ashleyxuu approved these changes

@shobsi shobsi Awaiting requested review from shobsi

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GarrettWu @ashleyxuu