feat: expose DataFrame.bqclient to assist in integrations
#519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
product-auto-label
bot
added
the
api: bigquery
tswast
changed the title
DataFrame.session to assist in integrationsDataFrame.bqclient to assist in integrations
junyazhang
approved these changes
Mar 26, 2024
| @@ -1,5 +1,27 @@ | |||
| { | |||
| "cells": [ | |||
| { | |||
| "cell_type": "code", | |||
| "execution_count": 1, | |||
There was a problem hiding this comment.
Just curious, how much do we care about these execution_count in notebooks? We are having two execution_count = 1 in this file.
There was a problem hiding this comment.
I don't think we really care. I recommend using the ReviewNB link above to review as a rendered version: #519 (comment)
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [] | ||
| } |
There was a problem hiding this comment.
Is this empty cell (line 416-422) intended here?
There was a problem hiding this comment.
Good catch. I've removed the empty cells and made an update to the "Returning a BigQuery DataFrames (bigframes) DataFrame" sample.
Genesis929
pushed a commit
that referenced
this pull request
Apr 9, 2024
* feat: expose `DataFrame.session` to assist in integrations * add code sample for sharing when the service account is only known on the backend * expose bqclient instead * start a DF construction sample * finish read sample
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕