fix: Fix case where df.peek would fail to execute even with force=True #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
tswast
reviewed
Mar 25, 2024
bigframes/core/tree_properties.py
Outdated
| @@ -25,3 +29,12 @@ def is_trivially_executable(node: nodes.BigFrameNode) -> bool: | |||
|
|
|||
| def local_only(node: nodes.BigFrameNode) -> bool: | |||
| return all(isinstance(node, nodes.ReadLocalNode) for node in node.roots) | |||
|
|
|||
|
|
|||
| @functools.cache | |||
There was a problem hiding this comment.
Would this get unwieldy with local data? I worry about that Feather data getting stored forever.
There was a problem hiding this comment.
Yeah, not sure why I put that cache decorator. Would take a really long time for the cache to get too big though. Removed and will figure out the whole property caching thing later.
tswast
reviewed
Mar 26, 2024
Added
Now forcing the materialization after caching. |
tswast
approved these changes
Mar 29, 2024
Genesis929
pushed a commit
that referenced
this pull request
Apr 9, 2024
#511) * fix: Fix case where df.peek would fail to execute even with force=True * remove cache from peekable property * if force=True always peek after caching even if peeking inefficient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕