Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use actual BigQuery types rather than ibis types in to_pandas #500

Merged
merged 3 commits into from
Mar 25, 2024
Merged

fix: Use actual BigQuery types rather than ibis types in to_pandas #500

merged 3 commits into from
Mar 25, 2024

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners March 22, 2024 22:49
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 22, 2024
@TrevorBergeron TrevorBergeron changed the title fix: use actual bigframes types rather than ibis types in to_pandas fix: Use actual BigQuery types rather than ibis types in to_pandas Mar 22, 2024
@tswast tswast merged commit 82b4f91 into main Mar 25, 2024
16 checks passed
@tswast tswast deleted the use_bf_result_types branch March 25, 2024 14:49
@release-please release-please bot mentioned this pull request Mar 25, 2024
Merged
Genesis929 pushed a commit that referenced this pull request Apr 9, 2024
@TrevorBergeron @Genesis929
fix: Use actual BigQuery types rather than ibis types in to_pandas (#500
73dbff5 
)

* fix: use actual bigframes types rather than ibis types in to_pandas

* Use ibis function that properly converts nested bq datatypes to ibis type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@GarrettWu GarrettWu Awaiting requested review from GarrettWu GarrettWu is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrevorBergeron @tswast