Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set force=True by default in DataFrame.peek() #469

Merged
merged 1 commit into from
Mar 19, 2024
Merged

feat: set force=True by default in DataFrame.peek() #469

merged 1 commit into from
Mar 19, 2024

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Mar 19, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 330331252
🦕

@tswast tswast requested review from a team as code owners March 19, 2024 15:46
@tswast tswast requested a review from chelsea-lin March 19, 2024 15:46
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 19, 2024
chelsea-lin
chelsea-lin approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast tswast merged commit 4e8e97d into main Mar 19, 2024
15 checks passed
@tswast tswast deleted the tswast-peek branch March 19, 2024 18:30
@release-please release-please bot mentioned this pull request Mar 19, 2024
Merged
TrevorBergeron pushed a commit that referenced this pull request Mar 20, 2024
@tswast @TrevorBergeron
feat: set force=True by default in DataFrame.peek() (#469)
347e70a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tswast @chelsea-lin