fix: renable to_csv and to_json related tests #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
4 tasks
chelsea-lin
force-pushed
the
main_chelsealin_reenabletocsvtests
branch
3 times, most recently
from
405ca71 to
0a39020
Compare
product-auto-label
bot
added
size: s
chelsea-lin
force-pushed
the
main_chelsealin_reenabletocsvtests
branch
from
e3fd6bf to
7b00656
Compare
shobsi
reviewed
Mar 20, 2024
chelsea-lin
force-pushed
the
main_chelsealin_reenabletocsvtests
branch
from
7b00656 to
48c8038
Compare
product-auto-label
bot
added
size: m
shobsi
reviewed
Mar 20, 2024
| @@ -19,7 +19,11 @@ | |||
| import pyarrow as pa | |||
| import pytest | |||
|
|
|||
| from tests.system.utils import assert_pandas_df_equal, convert_pandas_dtypes | |||
| from tests.system.utils import ( | |||
There was a problem hiding this comment.
go/pystyle#imports Use import statements for packages and modules only, not for individual types, classes, or functions.
There was a problem hiding this comment.
Trying to fix most files in this PR but leave series.py as it is, to avoid expanding this PR with many unrelated changes.
shobsi
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.