Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: exclude remote models for .register() #465

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

GarrettWu
Copy link
Contributor

@GarrettWu GarrettWu commented Mar 19, 2024

BEGIN_COMMIT_OVERRIDE
fix!: exclude remote models for .register() (#465)

Release-As: 0.26.0
END_COMMIT_OVERRIDE

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@GarrettWu GarrettWu requested review from a team as code owners March 19, 2024 01:12
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 19, 2024
@GarrettWu GarrettWu changed the title fix: exclude remote models for .register() fix!: exclude remote models for .register() Mar 19, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Mar 19, 2024
Copy link
Contributor

@ashleyxuu ashleyxuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we want to exclude remote models .register() for LLM class?

@GarrettWu
Copy link
Contributor Author

Any reason we want to exclude remote models .register() for LLM class?

Those remote models can be registered, but can't be deployed in Vertex. There was a discrepancy in BQML that CREATE MODEL can't register on remote model types, but ALTER MODEL can. In theory, no reason to register an already deployed model endpoint.

@GarrettWu GarrettWu merged commit 73fe0f8 into main Mar 19, 2024
14 of 15 checks passed
@GarrettWu GarrettWu deleted the garrettwu-register branch March 19, 2024 18:11
TrevorBergeron pushed a commit that referenced this pull request Mar 20, 2024
* fix: exclude remote models for .register()

* fix mypy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants