Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: raise ValueError when read_pandas() receives a bigframes DataFrame #447

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Mar 15, 2024

This should make debugging easier for users who mix up the type of their DataFrame.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 292088543
🦕

@tswast tswast requested review from a team as code owners March 15, 2024 15:56
@tswast tswast requested a review from ashleyxuu March 15, 2024 15:56
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 15, 2024
@tswast tswast merged commit b28f9fd into main Mar 15, 2024
14 of 15 checks passed
@tswast tswast deleted the b292088543-read_pandas-bfdf branch March 15, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants