Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add the docs for loc and iloc indexers #446

Merged
merged 6 commits into from
Mar 18, 2024

Conversation

ashleyxuu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ashleyxuu ashleyxuu requested review from a team as code owners March 15, 2024 05:10
@ashleyxuu ashleyxuu requested a review from tswast March 15, 2024 05:10
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 15, 2024
@ashleyxuu ashleyxuu force-pushed the ashleyxu-add-indexers-docs branch from 928adad to 3d8270a Compare March 15, 2024 05:18
@tswast tswast changed the title docs:add the docs for loc and iloc indexers docs: add the docs for loc and iloc indexers Mar 15, 2024
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the iloc, loc docstrings in

and to point to the corresponding indexer class in the Returns: section.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Mar 15, 2024
@ashleyxuu ashleyxuu requested a review from tswast March 15, 2024 17:11
@ashleyxuu ashleyxuu force-pushed the ashleyxu-add-indexers-docs branch from 5d913e7 to af39c20 Compare March 15, 2024 17:13
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ashleyxuu ashleyxuu added the automerge Merge the pull request once unit tests and other checks pass. label Mar 18, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 14ab8d8 into main Mar 18, 2024
14 of 15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the ashleyxu-add-indexers-docs branch March 18, 2024 17:58
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants