-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: (Series|DataFrame).plot.(line|area|scatter) #431
Conversation
b6eca40
to
276f228
Compare
return ( | ||
data.sample(n=sampling_n, random_state=sampling_random_state) | ||
.to_pandas() | ||
.sort_index() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is the sort necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the index of df.sample
is not sorted as https://screenshot.googleplex.com/9nhptZFVA8sZJCz
36bd746
to
3dd4a19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, we can follow up later on how to preserve ordering when sampling
d792f25
to
b462808
Compare
Internal bugs: