Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (Series|DataFrame).plot.(line|area|scatter) #431

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

chelsea-lin
Copy link
Contributor

@chelsea-lin chelsea-lin commented Mar 12, 2024

Internal bugs:

  • line: b/322177942
  • scatter: b/322178336
  • area: b/322178394

@chelsea-lin chelsea-lin requested review from a team as code owners March 12, 2024 22:51
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 12, 2024
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_line branch from b6eca40 to 276f228 Compare March 12, 2024 23:26
return (
data.sample(n=sampling_n, random_state=sampling_random_state)
.to_pandas()
.sort_index()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the sort necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the index of df.sample is not sorted as https://screenshot.googleplex.com/9nhptZFVA8sZJCz

third_party/bigframes_vendored/pandas/plotting/_core.py Outdated Show resolved Hide resolved
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_line branch from 36bd746 to 3dd4a19 Compare March 13, 2024 22:54
Copy link
Contributor

@TrevorBergeron TrevorBergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, we can follow up later on how to preserve ordering when sampling

@chelsea-lin chelsea-lin force-pushed the main_chelsealin_line branch from d792f25 to b462808 Compare March 14, 2024 05:26
@chelsea-lin chelsea-lin merged commit 0772510 into main Mar 14, 2024
14 of 15 checks passed
@chelsea-lin chelsea-lin deleted the main_chelsealin_line branch March 14, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants