-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move third_party.bigframes_vendored
to bigframes_vendored
#424
Conversation
This will avoid potential conflicts when run from a location that contains the commonly named `third_party` directory. Fixes internal issue 328781348.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious. If we want to avoid third_party, why can't we just remove it from the path?
We need it to signify that this code has a different copyright (isn't covered under Google CLA) per go/thirdparty/non-google3 policy. |
Note: please don't manually merge unless this has been synced to main. I'm using Edit: Update: |
This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.
This will avoid potential conflicts when run from a location that contains the commonly named
third_party
directory.Note: I followed the instructions here: https://stackoverflow.com/a/17179022/101923 but I also had to add a
pyproject.toml
file to support editable installations (see: pypa/setuptools#230 (comment)).Fixes internal issue 328781348.
🦕