Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move third_party.bigframes_vendored to bigframes_vendored #424

Merged
merged 10 commits into from
Mar 12, 2024

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Mar 8, 2024

This will avoid potential conflicts when run from a location that contains the commonly named third_party directory.

Note: I followed the instructions here: https://stackoverflow.com/a/17179022/101923 but I also had to add a pyproject.toml file to support editable installations (see: pypa/setuptools#230 (comment)).

Fixes internal issue 328781348.
🦕

This will avoid potential conflicts when run from a location that
contains the commonly named `third_party` directory.

Fixes internal issue 328781348.
@tswast tswast requested review from a team as code owners March 8, 2024 18:43
@tswast tswast requested a review from stevewalker-de March 8, 2024 18:43
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 8, 2024
@tswast tswast requested review from parthea and removed request for stevewalker-de March 8, 2024 18:43
@tswast tswast requested a review from GarrettWu March 8, 2024 22:56
@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 11, 2024
GarrettWu
GarrettWu previously approved these changes Mar 11, 2024
Copy link
Contributor

@GarrettWu GarrettWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious. If we want to avoid third_party, why can't we just remove it from the path?

@tswast
Copy link
Collaborator Author

tswast commented Mar 12, 2024

Just curious. If we want to avoid third_party, why can't we just remove it from the path?

We need it to signify that this code has a different copyright (isn't covered under Google CLA) per go/thirdparty/non-google3 policy.

@tswast tswast added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Mar 12, 2024
@tswast
Copy link
Collaborator Author

tswast commented Mar 12, 2024

Note: please don't manually merge unless this has been synced to main. I'm using automerge: exact which should ensure this change only merges if synced to main when merged via automerge.

Edit: Update: automerge: exact doesn't affect if it's synced with main or not. It affects if the review is on the latest commit inside this pull request, which isn't really what I wanted. I've instead updated the Pull Request settings to always suggest update to main but it's not a requirement still.

@gcf-merge-on-green gcf-merge-on-green bot dismissed GarrettWu’s stale review March 12, 2024 16:10

This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.

@tswast tswast removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Mar 12, 2024
@tswast tswast requested a review from GarrettWu March 12, 2024 17:41
@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Mar 12, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 763edeb into main Mar 12, 2024
14 of 15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the b328781348-third_party branch March 12, 2024 17:46
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants