Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix the note rendering for DataFrames methods: nlargest, nsmallest #417

Merged
merged 4 commits into from
Mar 7, 2024
Merged

docs: fix the note rendering for DataFrames methods: nlargest, nsmallest #417

merged 4 commits into from
Mar 7, 2024

Conversation

ashleyxuu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue #328445384 🦕

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 6, 2024
@ashleyxuu ashleyxuu marked this pull request as ready for review March 6, 2024 18:16
@ashleyxuu ashleyxuu requested review from a team as code owners March 6, 2024 18:17
@ashleyxuu ashleyxuu requested a review from Genesis929 March 6, 2024 18:17
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Mar 6, 2024
@ashleyxuu ashleyxuu requested a review from shobsi March 6, 2024 18:17
@ashleyxuu ashleyxuu added the automerge Merge the pull request once unit tests and other checks pass. label Mar 7, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 38bd2ba into main Mar 7, 2024
14 of 15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the ashleyxu-fix-note-rendering branch March 7, 2024 18:38
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 7, 2024
@release-please release-please bot mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shobsi shobsi shobsi approved these changes

@Genesis929 Genesis929 Awaiting requested review from Genesis929 Genesis929 is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashleyxuu @shobsi @GarrettWu