Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support CMEK for BQ tables #403

Merged
merged 25 commits into from
Mar 9, 2024
Merged

feat: Support CMEK for BQ tables #403

merged 25 commits into from
Mar 9, 2024

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Feb 29, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue #327083723 🦕

@shobsi shobsi requested review from a team as code owners February 29, 2024 18:39
@shobsi shobsi requested a review from junyazhang February 29, 2024 18:39
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Feb 29, 2024
@shobsi shobsi marked this pull request as draft February 29, 2024 18:47
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Mar 1, 2024
shobsi
shobsi commented Mar 1, 2024
View reviewed changes
bigframes/session/clients.py Outdated Show resolved Hide resolved
@shobsi shobsi requested review from tswast and GarrettWu and removed request for junyazhang March 5, 2024 02:15
@shobsi shobsi marked this pull request as ready for review March 5, 2024 07:51
GarrettWu
GarrettWu reviewed Mar 5, 2024
View reviewed changes
bigframes/session/__init__.py Outdated Show resolved Hide resolved
bigframes/session/__init__.py Outdated Show resolved Hide resolved
bigframes/session/clients.py Outdated Show resolved Hide resolved
GarrettWu
GarrettWu approved these changes Mar 7, 2024
View reviewed changes
bigframes/session/clients.py Outdated Show resolved Hide resolved
bigframes/session/__init__.py Outdated Show resolved Hide resolved
@shobsi shobsi merged commit 9a678e3 into main Mar 9, 2024
15 checks passed
@shobsi shobsi deleted the shobs-cmek branch March 9, 2024 02:14
@release-please release-please bot mentioned this pull request Mar 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

@tswast tswast Awaiting requested review from tswast

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shobsi @GarrettWu