Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add configuration option to read_gbq #401

Merged
merged 14 commits into from
Mar 22, 2024
Merged

feat: add configuration option to read_gbq #401

merged 14 commits into from
Mar 22, 2024

Conversation

Genesis929
Copy link
Collaborator

@Genesis929 Genesis929 commented Feb 28, 2024 •
edited by tswast
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #384 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Feb 28, 2024
@tswast tswast mentioned this pull request Mar 8, 2024
Closed
@Genesis929 Genesis929 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 14, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 14, 2024
@Genesis929 Genesis929 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 14, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 14, 2024
@Genesis929 Genesis929 marked this pull request as ready for review March 14, 2024 18:33
@Genesis929 Genesis929 requested review from a team as code owners March 14, 2024 18:33
shobsi
shobsi reviewed Mar 21, 2024
View reviewed changes
bigframes/session/__init__.py Show resolved Hide resolved
tests/system/small/test_session.py Outdated Show resolved Hide resolved
tests/system/small/test_session.py Show resolved Hide resolved
tests/system/small/test_session.py Outdated Show resolved Hide resolved
@Genesis929 Genesis929 requested a review from shobsi March 21, 2024 20:21
shobsi
shobsi reviewed Mar 22, 2024
View reviewed changes
Copy link
Contributor

@shobsi shobsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for all checks to pass before merging

@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Mar 22, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 85cede2 into main Mar 22, 2024
15 of 16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the config-read-gbq-huanc branch March 22, 2024 19:04
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 22, 2024
@release-please release-please bot mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shobsi shobsi shobsi approved these changes

@milkshakeiii milkshakeiii Awaiting requested review from milkshakeiii milkshakeiii is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for query parameterization
3 participants
@Genesis929 @shobsi @tswast