feat: add TextEmbedding model version support #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
ashleyxuu
approved these changes
Feb 29, 2024
| @@ -266,6 +266,9 @@ class PaLM2TextEmbeddingGenerator(base.Predictor): | |||
| The model for text embedding. “textembedding-gecko” returns model embeddings for text inputs. | |||
| "textembedding-gecko-multilingual" returns model embeddings for text inputs which support over 100 languages | |||
| Default to "textembedding-gecko". | |||
| version (str or None): | |||
There was a problem hiding this comment.
Should we default to @latest?
There was a problem hiding this comment.
Not so sure, but default and latest may or may not be the same. I'll rely on Vertex default.
| @@ -56,3 +56,16 @@ def _convert_to_series(frame: ArrayType) -> bpd.Series: | |||
| raise ValueError( | |||
| f"Unsupported type {type(frame)} to convert to Series. {constants.FEEDBACK_LINK}" | |||
| ) | |||
|
|
|||
|
|
|||
| def parse_model_endpoint(model_endpoint: str) -> tuple[str, Optional[str]]: | |||
There was a problem hiding this comment.
Better to add unit test for this newly added method?
GarrettWu
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕