Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exceptions raised in apply from a remote_function now surface in the client #387

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Feb 22, 2024

BEGIN_COMMIT_OVERRIDE
fix: code exception in remote_function now prevents retry and surfaces in the client (#387)
END_COMMIT_OVERRIDE

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 309699263 🦕

@shobsi shobsi requested review from a team as code owners February 22, 2024 03:12
@shobsi shobsi requested a review from tswast February 22, 2024 03:12
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Feb 22, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Feb 22, 2024
@tswast tswast changed the title feat: Enable remote_function return proper error fix: exceptions raised in apply from a remote_function now surface in the client Feb 29, 2024
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I've filed b/327662690 as a follow-up for an automatic call to _cached() inside apply() so that these errors happen as soon as possible. Since a remote function might do something non-deterministic, we need to do that to keep our results deterministic anyway.

@shobsi shobsi added the automerge Merge the pull request once unit tests and other checks pass. label Feb 29, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit dd3643d into main Feb 29, 2024
14 of 15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the shobs-rf-err-handle branch February 29, 2024 23:10
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants