Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable regional endpoints for me-central2 #386

Merged
merged 3 commits into from
Feb 24, 2024
Merged

feat: Enable regional endpoints for me-central2 #386

merged 3 commits into from
Feb 24, 2024

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Feb 20, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 312304785 🦕

@shobsi shobsi requested review from a team as code owners February 20, 2024 23:15
@shobsi shobsi requested a review from ashleyxuu February 20, 2024 23:15
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Feb 20, 2024
@shobsi shobsi added the automerge Merge the pull request once unit tests and other checks pass. label Feb 24, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 469674d into main Feb 24, 2024
14 of 15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the shobs-rep branch February 24, 2024 05:56
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 24, 2024
@release-please release-please bot mentioned this pull request Feb 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleyxuu ashleyxuu ashleyxuu approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shobsi @ashleyxuu