Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add XGBoostModel #363

Merged
merged 8 commits into from
Feb 7, 2024
Merged

feat: add XGBoostModel #363

merged 8 commits into from
Feb 7, 2024

Conversation

ashleyxuu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal #321809936 🦕

@ashleyxuu ashleyxuu requested a review from GarrettWu January 31, 2024 20:06
@ashleyxuu ashleyxuu requested review from a team as code owners January 31, 2024 20:06
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 31, 2024
GarrettWu
GarrettWu reviewed Feb 6, 2024
View reviewed changes
bigframes/ml/imported.py Outdated Show resolved Hide resolved
@ashleyxuu ashleyxuu added the automerge Merge the pull request once unit tests and other checks pass. label Feb 7, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit d5518b2 into main Feb 7, 2024
14 of 15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the ashleyxu-add-imported-xgboost-model branch February 7, 2024 23:10
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 7, 2024
@release-please release-please bot mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashleyxuu @GarrettWu