feat: limited support of lamdas in Series.apply
#345
Conversation
product-auto-label
bot
added
size: s
product-auto-label
bot
added
size: m
| There is a limited support of simple functions and lambdas which can be | ||
| operated directly (without converting into a `remote_function`) on the | ||
| BigQuery DataFrames objects. This approach takes advantage of a nuance | ||
| in the way BigQuery DataFrames objects are modeled internally and works | ||
| only if the function body contains only arithmatic or logical operators. |
There was a problem hiding this comment.
I'd rather we rephrase this as "ufunc" emulation support, as defined in the pandas docs. https://pandas.pydata.org/docs/reference/api/pandas.Series.apply.html
bigframes/series.py
Outdated
| ) | ||
|
|
||
| if not hasattr(func, "bigframes_remote_function"): | ||
| return func(self) |
There was a problem hiding this comment.
Let's catch exceptions here and if there's a "message" attribute, append a suggestion to try remote_function, instead.
bigframes/series.py
Outdated
| # supported on a Series. Let's guide the customer to use a | ||
| # remote function instead | ||
| if hasattr(ex, "message"): | ||
| ex.message += "\n{_remote_function_recommendation_message}" |
There was a problem hiding this comment.
This needs to be an f string.
There was a problem hiding this comment.
Thanks for catching, corrected.
|
|
||
| if not hasattr(func, "bigframes_remote_function"): | ||
| try: | ||
| return func(self) |
There was a problem hiding this comment.
Since it may result in incorrect values if this isn't a true vectorized function, let's check for by_row=False. If by_row="compat" (default) then raise and suggest either remote_function or by_row=False.
product-auto-label
bot
added
size: l
bigframes/series.py
Outdated
| # It is not a remote function | ||
| # Then it must be a vectorized function that applies to the Series | ||
| # as a whole | ||
| assert ( |
There was a problem hiding this comment.
AssertionError is a bit of an odd one to raise. Usually that means some invariant that we never expect to happen has violated. Please raise ValueError instead.
shobsi
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
BEGIN_COMMIT_OVERRIDE
feat: limited support of lambdas in
Series.apply(#345)END_COMMIT_OVERRIDE
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Partially fixes internal issue 295964341 🦕