Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve error message for drive based BQ table reads #344

Merged
merged 5 commits into from
Jan 26, 2024

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Jan 24, 2024

This change will append a helpful documentation link to troubleshoot drive permission denied error https://screenshot.googleplex.com/96rLqtEUcrxzd39.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 304826407 🦕

@shobsi shobsi requested review from a team as code owners January 24, 2024 00:43
@shobsi shobsi requested a review from tswast January 24, 2024 00:43
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 24, 2024
@tswast
Copy link
Collaborator

tswast commented Jan 25, 2024

Would be good to add a unit test for this logic to double-check that appending to the message like this doesn't cause a different exception.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jan 25, 2024
@shobsi shobsi merged commit 0794788 into main Jan 26, 2024
15 checks passed
@shobsi shobsi deleted the shobs-gdrive-access-error branch January 26, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants