Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix DataFrameGroupby.agg() issue with as_index=False #273

Merged
merged 11 commits into from
Dec 19, 2023
Merged

fix: fix DataFrameGroupby.agg() issue with as_index=False #273

merged 11 commits into from
Dec 19, 2023

Conversation

TrevorBergeron
Copy link
Contributor

@TrevorBergeron TrevorBergeron commented Dec 14, 2023 •
edited by shobsi
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #271 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners December 14, 2023 00:40
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Dec 14, 2023
@TrevorBergeron TrevorBergeron mentioned this pull request Dec 14, 2023
Closed
@TrevorBergeron TrevorBergeron added the automerge Merge the pull request once unit tests and other checks pass. label Dec 19, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit ab49350 into main Dec 19, 2023
14 of 15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the agg_bug branch December 19, 2023 20:32
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 19, 2023
@release-please release-please bot mentioned this pull request Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shobsi shobsi shobsi approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

groupby(as_index=False).agg() cause error on Google Colab environment
2 participants
@TrevorBergeron @shobsi