Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add LogisticRegression.predict_explain() to generate ML.EXPLAIN_PREDICT columns #1222

Merged
merged 5 commits into from
Dec 18, 2024
Merged

feat: add LogisticRegression.predict_explain() to generate ML.EXPLAIN_PREDICT columns #1222

merged 5 commits into from
Dec 18, 2024

Conversation

arwas11
Copy link
Contributor

@arwas11 arwas11 commented Dec 16, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
    • predict_explain: screen/AGL7LuKUavHmYbn

Fixes #379743612 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Dec 16, 2024
@arwas11 arwas11 changed the title feat: add LogisticRegression.predict_explain() to generate ML.EXPLAIN_PREDICT columns feat: add LogisticRegression.predict_explain() to generate ML.EXPLAIN_PREDICT columns Dec 16, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Dec 16, 2024
@arwas11 arwas11 force-pushed the b379743612-ml-logistic-regression-explain-predict branch from e12b62f to d333fdd Compare December 16, 2024 23:03
tswast
tswast reviewed Dec 17, 2024
View reviewed changes
tests/system/small/ml/test_linear_model.py Outdated Show resolved Hide resolved
tests/system/small/ml/test_linear_model.py Outdated Show resolved Hide resolved
tests/system/small/ml/test_linear_model.py Show resolved Hide resolved
tests/system/small/ml/test_linear_model.py Show resolved Hide resolved
@arwas11 arwas11 marked this pull request as ready for review December 17, 2024 16:50
@arwas11 arwas11 requested review from a team as code owners December 17, 2024 16:50
@arwas11 arwas11 requested a review from chelsea-lin December 17, 2024 16:50
@tswast
Copy link
Collaborator

tswast commented Dec 17, 2024

e2e failure FAILED tests/system/large/ml/test_model_selection.py::test_cross_validate[4-4] doesn't appear related.

tswast
tswast approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arwas11 arwas11 enabled auto-merge (squash) December 17, 2024 19:33
@arwas11 arwas11 merged commit bcbc732 into main Dec 18, 2024
22 checks passed
@arwas11 arwas11 deleted the b379743612-ml-logistic-regression-explain-predict branch December 18, 2024 16:51
@release-please release-please bot mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@chelsea-lin chelsea-lin Awaiting requested review from chelsea-lin chelsea-lin is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

@sycai sycai

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arwas11 @tswast @sycai