Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ARIMAPlus.predict_explain() to generate forecasts with explanation columns #1177

Merged
merged 28 commits into from
Dec 9, 2024
Merged

feat: add ARIMAPlus.predict_explain() to generate forecasts with explanation columns #1177

merged 28 commits into from
Dec 9, 2024

Conversation

rey-esp
Copy link
Contributor

@rey-esp rey-esp commented Nov 26, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Nov 26, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Nov 26, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Nov 26, 2024
@chelsea-lin
Copy link
Contributor

The debug.ipynb is not expected to be pushed. Hence, I reverted this commit through git revert f6dd455. Thjanks @rey-esp

@chelsea-lin
Copy link
Contributor

To fix lint tests, please run nox -r -s format and then run nox -r -s lint lint_setup_py commands. They can automatically format codes and check lint.

@chelsea-lin chelsea-lin changed the title feat: add predict_explain() and predict_forecast() feat: add ARIMAPlus.predict_explain() to generate forecasts with explanation columns Nov 26, 2024
@rey-esp rey-esp marked this pull request as ready for review November 26, 2024 20:21
@rey-esp rey-esp requested review from a team as code owners November 26, 2024 20:21
tswast
tswast reviewed Dec 2, 2024
View reviewed changes
bigframes/ml/forecasting.py Outdated Show resolved Hide resolved
bigframes/ml/forecasting.py Show resolved Hide resolved
gcf-owl-bot bot and others added 14 commits December 3, 2024 20:09
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
48c81ed 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@rey-esp
Merge branch 'main' into ml-predict-explain
c22eec8
@rey-esp
add unit test file - bare bones
706a1ae
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
79a5359 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@rey-esp
Merge branch 'main' into ml-predict-explain
7922d64
@rey-esp
Merge branch 'main' into ml-predict-explain
aba6aca
@rey-esp
Merge branch 'main' into ml-predict-explain
b9343cf
@rey-esp
Merge branch 'main' into ml-predict-explain
ac271ff
@rey-esp
fixed tests
3befd2e
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
3fbcb64 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@rey-esp
lint
04d1fb4
@rey-esp
Merge branch 'ml-predict-explain' of github.com:googleapis/python-big…
75e2994 
…query-dataframes into ml-predict-explain
@rey-esp
lint
6bfb1d3
@rey-esp
fix test: float -> int
e2eb29d
tswast
tswast approved these changes Dec 9, 2024
View reviewed changes
tests/system/small/ml/test_forecasting.py
"seasonal_period_daily",
"holiday_effect",
}
assert expected_columns <= prediction_columns
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast
Copy link
Collaborator

tswast commented Dec 9, 2024

doctest failures is FAILED bigframes/operations/semantics.py::bigframes.operations.semantics.Semantics.sim_join and appears unrelated.

@tswast tswast enabled auto-merge (squash) December 9, 2024 23:01
@tswast tswast merged commit 05f8b4d into main Dec 9, 2024
22 of 23 checks passed
@tswast tswast deleted the ml-predict-explain branch December 9, 2024 23:14
@release-please release-please bot mentioned this pull request Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@chelsea-lin chelsea-lin Awaiting requested review from chelsea-lin

Assignees

@Genesis929 Genesis929

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rey-esp @chelsea-lin @tswast @Genesis929