-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update bigframes.pandas.Index
docstrings
#1144
Conversation
f3a0332
to
1871ed2
Compare
…-type-annotation-index
…-type-annotation-index
…-type-annotation-index
bigframes.pandas.Index
docstringsbigframes.pandas.Index
docstrings
@@ -134,7 +134,6 @@ def name(self, value: blocks.Label): | |||
|
|||
@property | |||
def names(self) -> typing.Sequence[blocks.Label]: | |||
"""Returns the names of the Index.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For context for Huan, these are borrowed from pandas, so need to come from third_party
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! The examples make me happy.
Please make sure |
We're still getting quite a few doctest failures. Please fix.
|
>>> bpd.Index([1, 2, 3]).all() | ||
True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, pandas
gives a numpy
object in some versions. It should be interchangeable with a bool, but it has a different repr. Try this (here and in other failing tests):
>>> bpd.Index([1, 2, 3]).all() | |
True | |
>>> bool(bpd.Index([1, 2, 3]).all()) | |
True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion, I'll give it a try.
…-type-annotation-index
…-type-annotation-index
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
values
: screen/4ViVk2h34LfgD9rshape
: screen/3Ld4EGsxTfmZnVhnlevels
: screen/6TYw5qPWkzpKFq7is_unique
: screen/7grdQKsxVLv6mGshas_duplicates
: screen/7CQgVfVsiNtkqXwdtype
: screen/ 75HzCFFRdPbJVCndtypes
: screen/6i8zVhpfksEdzVRT
: screen/9ZuShN6bfoWvKxncopy
: screen/8pMYrfDSaLqcdQMastype
: screen/8AsiSd6DvjszHkQ, screen/get_level_values
: screen/to_series
: screen/, screen/isin
: screen/3G6UfR5fTocREdn, screen/86tTDdCKnSWdVZxall
: screen/8w3maL5nEkp9Jko, screen/AT9SB55jdUkwViCany
: screen/6zbST5graLENBcXmin
: screen/c38rufXA7pdZq22max
: screen/8RpYJJTBCcgZZ3xargmin
: screen/7CqEuNjhjibmXJE, screen/5D67hEv7okLXhVGargmax
: screen/4ojQtUpLqEW2qDE, screen/6i63mdEUgFaVArHnunique
: screen/ 4zAMoEvxFGLQ2vTsort_values
: screen/5nsxukvUq5raPHe, screen/AcviuSvz4m5fuTsvalue_counts
: screen/AMh3QtVxLVBhPDT, screen/SKjbGAzjEZhAswS, screen,/ByGcJANuAiJkZjKfillna
: screen/4f7nZJRqBZ3Vyb2rename
: screen/4zvSA3knkh6stpBdrop
: screen/7dTVqr9DAEtBUsQdropna
: screen/5cxdPbQjSq8WHiydrop_duplicates
: screen/BkKbQXgvZRPfEbN, screen/3ggJqu9RQj6BqFYFixes #296390934 🦕