Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support json_extract_string_array in the bigquery module #1131

Merged
merged 2 commits into from
Nov 7, 2024
Merged

feat: support json_extract_string_array in the bigquery module #1131

merged 2 commits into from
Nov 7, 2024

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Nov 5, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary): screen/7jpzC4dGTW8GsNC, screen/5Lef72nRdhijaz5

Fixes #<issue_number_goes_here> 🦕

@shobsi shobsi requested review from a team as code owners November 5, 2024 19:36
@shobsi shobsi requested a review from Genesis929 November 5, 2024 19:36
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 5, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Nov 5, 2024
@shobsi shobsi requested a review from TrevorBergeron November 5, 2024 19:37
@shobsi shobsi merged commit 4ef8bac into main Nov 7, 2024
23 checks passed
@shobsi shobsi deleted the shobs-json-extract-string-array branch November 7, 2024 10:25
@release-please release-please bot mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrevorBergeron TrevorBergeron TrevorBergeron approved these changes

@Genesis929 Genesis929 Awaiting requested review from Genesis929 Genesis929 is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

@liujiashang liujiashang

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shobsi @TrevorBergeron @liujiashang