Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document groupby.head and groupby.size methods #1111

Merged
merged 17 commits into from
Nov 12, 2024
Merged

docs: document groupby.head and groupby.size methods #1111

merged 17 commits into from
Nov 12, 2024

Conversation

arwas11
Copy link
Contributor

@arwas11 arwas11 commented Oct 24, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
    • head: screen/6AwYN3STkX3pS2c
    • size: screen/i8BuAneYbS4cTvW, screen/76NHbqGhnUJM53p

Fixes #296390934 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 24, 2024
@arwas11 arwas11 requested a review from tswast October 24, 2024 16:20
@arwas11 arwas11 marked this pull request as ready for review October 28, 2024 16:11
@arwas11 arwas11 requested review from a team as code owners October 28, 2024 16:11
@tswast tswast changed the title chore: add groupby.head and groupby.size methods docs: document groupby.head and groupby.size methods Oct 30, 2024
@tswast tswast enabled auto-merge (squash) October 30, 2024 16:36
@tswast tswast disabled auto-merge October 30, 2024 16:36
tswast
tswast requested changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but it seems doctest is failing. Please fix.

FAILED third_party/bigframes_vendored/pandas/core/groupby/__init__.py::groupby.GroupBy.head
FAILED third_party/bigframes_vendored/pandas/core/groupby/__init__.py::groupby.GroupBy.size

@arwas11 arwas11 requested a review from tswast November 6, 2024 17:07
@arwas11 arwas11 requested a review from Genesis929 November 8, 2024 19:55
@Genesis929 Genesis929 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 8, 2024
@tswast tswast enabled auto-merge (squash) November 12, 2024 17:53
@tswast tswast merged commit a61eb4d into main Nov 12, 2024
22 of 23 checks passed
@tswast tswast deleted the b296390934-docstrings-type-annotation2 branch November 12, 2024 18:08
@release-please release-please bot mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Genesis929 Genesis929 Genesis929 approved these changes

@tswast tswast tswast approved these changes

Assignees

@chelsea-lin chelsea-lin

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arwas11 @tswast @Genesis929 @yoshi-kokoro @chelsea-lin