Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update GroupBy docstrings #1103

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Conversation

arwas11
Copy link
Contributor

@arwas11 arwas11 commented Oct 22, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #296390934 🦕

@arwas11 arwas11 requested a review from tswast October 22, 2024 21:03
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 22, 2024
@arwas11 arwas11 marked this pull request as ready for review October 28, 2024 21:36
@arwas11 arwas11 requested review from a team as code owners October 28, 2024 21:36
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@tswast tswast enabled auto-merge (squash) October 30, 2024 16:35
@tswast tswast merged commit 9867a78 into main Oct 30, 2024
22 of 23 checks passed
@tswast tswast deleted the b296390934-docstrings-type-annotation1 branch October 30, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants