Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove index requirement from some dataframe APIs #1073

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fix: Remove index requirement from some dataframe APIs #1073

merged 2 commits into from
Oct 11, 2024

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners October 9, 2024 22:18
@TrevorBergeron TrevorBergeron requested a review from tswast October 9, 2024 22:18
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 9, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Oct 9, 2024
@TrevorBergeron TrevorBergeron requested review from shobsi and removed request for tswast October 10, 2024 16:13
@TrevorBergeron TrevorBergeron merged commit 2d16f6d into main Oct 11, 2024
22 of 23 checks passed
@TrevorBergeron TrevorBergeron deleted the null_index_fixes branch October 11, 2024 06:49
@release-please release-please bot mentioned this pull request Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shobsi shobsi shobsi approved these changes

Assignees

@liujiashang liujiashang

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrevorBergeron @shobsi @liujiashang