-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: limit pypi notebook to 7 days and add more info about differences with partial ordering mode #1013
Conversation
…es with partial ordering mode
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Notebook failure is "FAILED notebooks/remote_functions/remote_function_usecases.ipynb:: - ResourceExhausted: 429 Too many operations are currently being executed, try again later." not this notebook. |
@@ -40,6 +40,16 @@ | |||
"execution_count": 2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #5. last_30_days = now - datetime.timedelta(days=30)
This is not needed then.
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I just noticed that the max()
call is doing a 4+ TB query. I will try to fix that. The trouble with using last_7_days
for both is that I was getting empty results for the deps DataFrame. I will use the 30 day comparison for that to avoid the expensive max()
call.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕