From ad6746569b3af11be9d40805a1449ee1e89288dc Mon Sep 17 00:00:00 2001
From: Shobhit Singh <shobs@google.com>
Date: Thu, 21 Dec 2023 00:33:37 +0000
Subject: [PATCH] fix: make `Series.str.replace` work for simple strings (#285)

---
 bigframes/operations/__init__.py               |  2 +-
 tests/system/small/operations/test_strings.py  |  2 ++
 .../bigframes_vendored/pandas/core/series.py   | 18 ++++++++++++++++++
 3 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/bigframes/operations/__init__.py b/bigframes/operations/__init__.py
index 753870a42d..678774978a 100644
--- a/bigframes/operations/__init__.py
+++ b/bigframes/operations/__init__.py
@@ -385,7 +385,7 @@ def _as_ibis(self, x: ibis_types.Value):
             ibis_types.StringValue, ibis_types.literal(self._pat)
         )
         repl_str_value = typing.cast(
-            ibis_types.StringValue, ibis_types.literal(self._pat)
+            ibis_types.StringValue, ibis_types.literal(self._repl)
         )
 
         return typing.cast(ibis_types.StringValue, x).replace(
diff --git a/tests/system/small/operations/test_strings.py b/tests/system/small/operations/test_strings.py
index 27a35134d4..79f92c94b4 100644
--- a/tests/system/small/operations/test_strings.py
+++ b/tests/system/small/operations/test_strings.py
@@ -94,6 +94,8 @@ def test_str_extract(scalars_dfs, pat):
         (".*", "blah", True, 0, True),
         ("h.l", "blah", False, 0, True),
         (re.compile("(?i).e.."), "blah", None, 0, True),
+        ("H", "h", True, 0, False),
+        (", ", "__", True, 0, False),
     ],
 )
 def test_str_replace(scalars_dfs, pat, repl, case, flags, regex):
diff --git a/third_party/bigframes_vendored/pandas/core/series.py b/third_party/bigframes_vendored/pandas/core/series.py
index d054684598..366f32c77e 100644
--- a/third_party/bigframes_vendored/pandas/core/series.py
+++ b/third_party/bigframes_vendored/pandas/core/series.py
@@ -2304,6 +2304,24 @@ def str(self):
         NAs stay NA unless handled otherwise by a particular method. Patterned
         after Python’s string methods, with some inspiration from R’s stringr package.
 
+        **Examples:**
+
+            >>> import bigframes.pandas as bpd
+            >>> bpd.options.display.progress_bar = None
+
+            >>> s = bpd.Series(["A_Str_Series"])
+            >>> s
+            0    A_Str_Series
+            dtype: string
+
+            >>> s.str.lower()
+            0    a_str_series
+            dtype: string
+
+            >>> s.str.replace("_", "")
+            0    AStrSeries
+            dtype: string
+
         Returns:
             bigframes.operations.strings.StringMethods:
                 An accessor containing string methods.