-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(samples): add AutoML image classification sample #923
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
The build is failing: import tensorflow as tf That seems to be part of the testing pipeline, so not sure how to fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the PR title from "fix: ..." to "samples: ...".
"fix: ..." and "feat: ..." are reserved for Vertex SDK and the title content will be propagated to the Release Note.
Also, to add to @morgandu's comment, it's preferred if we don't refer to internal bug numbers that some users may not have access to. So, could the title also be changed to include a summary of what was actually fixed? That will make the Release Notes for this fix more useful. |
|
||
|
||
# [START aiplatform_sdk_predict_image_classification_sample] | ||
def predict_tabular_classification_sample( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this read predict_image_classification_sample
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that looks like a typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed it.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #202042079🦕