-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable feature store online serving #918
Merged
gcf-merge-on-green
merged 19 commits into
googleapis:main
from
morgandu:mor--feature-store-online-read
Jan 15, 2022
Merged
feat: enable feature store online serving #918
gcf-merge-on-green
merged 19 commits into
googleapis:main
from
morgandu:mor--feature-store-online-read
Jan 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgandu
changed the title
feat: add read in EntityType class to enable Featurestore Online Serving
feat: enable feature store online serving; add read method in EntityType class for reading entities feature values
Dec 17, 2021
…ype class for reading entities feature values
morgandu
force-pushed
the
mor--feature-store-online-read
branch
from
December 17, 2021 04:31
2e6d5ad
to
03dd07c
Compare
sasha-gitg
requested changes
Dec 20, 2021
Co-authored-by: sasha-gitg <[email protected]>
Co-authored-by: sasha-gitg <[email protected]>
Co-authored-by: sasha-gitg <[email protected]>
Co-authored-by: sasha-gitg <[email protected]>
Co-authored-by: Yicheng Fang <[email protected]>
…tadata, feature_ids, _load_read_feature_values_response_to_dataframe
sasha-gitg
approved these changes
Dec 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please get approval from Diem/FS team.
diemtvu
reviewed
Dec 22, 2021
diemtvu
reviewed
Jan 5, 2022
diemtvu
reviewed
Jan 14, 2022
…e conversion, update tests with explicit expected df
diemtvu
approved these changes
Jan 14, 2022
morgandu
changed the title
feat: enable feature store online serving; add read method in EntityType class for reading entities feature values
feat: enable feature store online serving
Jan 15, 2022
morgandu
added
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Jan 15, 2022
import pandas as pd | ||
except ImportError: | ||
raise ImportError( | ||
f"Pandas are not installed. Please install pandas to use " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pandas library is not installed?
kweinmeister
approved these changes
Jan 15, 2022
Missing PR description? |
morgandu
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Jan 15, 2022
morgandu
added
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Jan 15, 2022
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_instantiate_featurestore_online_client
, andread
method inEntityType
class to enable feature store online serving