Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: show inherited SDK methods in pydoc #1707

Merged
merged 3 commits into from
Sep 30, 2022
Merged

docs: show inherited SDK methods in pydoc #1707

merged 3 commits into from
Sep 30, 2022

Conversation

jaycee-li
Copy link
Contributor

Fixes b/249069357

Show inherited methods for all the classes in SDK. And delete repeated methods for AutoMLForecastingTrainingJob and SequenceToSequencePlusForecastingTrainingJob

@jaycee-li jaycee-li requested review from a team as code owners September 29, 2022 17:34
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Sep 29, 2022
@jaycee-li jaycee-li changed the title fix: show inherited SDK methods in pydoc docs: show inherited SDK methods in pydoc Sep 29, 2022
dandhlee
dandhlee approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure if adding :inherited-members: adds more value for c.g.c. docs, I'll look into it. Otherwise LGTM to remove the duplicate entries.

@jaycee-li
Copy link
Contributor Author

@dandhlee Thanks for the review! What I'm trying to change is this page. I'm not familiar with c.g.c docs so please let me know if deleting those two methods breaks c.g.c

@dandhlee
Copy link
Contributor

I don't think it'll break anything since you're only removing duplicate entries. The inheritance may not show, but that's on me - don't have to worry for the scope of this PR 😄

@jaycee-li
Copy link
Contributor Author

I don't think it'll break anything since you're only removing duplicate entries. The inheritance may not show, but that's on me - don't have to worry for the scope of this PR 😄

Got it. Thank you!

@rosiezou rosiezou added the automerge Merge the pull request once unit tests and other checks pass. label Sep 30, 2022
@jaycee-li jaycee-li merged commit 2b7583b into googleapis:main Sep 30, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 30, 2022
@release-please release-please bot mentioned this pull request Sep 30, 2022
Merged
@jaycee-li jaycee-li deleted the update-pydoc branch September 30, 2022 23:37
@release-please release-please bot mentioned this pull request Jun 8, 2023
Closed
@release-please release-please bot mentioned this pull request Aug 25, 2023
Closed
@release-please release-please bot mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandhlee dandhlee dandhlee approved these changes

@sasha-gitg sasha-gitg sasha-gitg approved these changes

@nayaknishant nayaknishant nayaknishant approved these changes

Assignees
No one assigned
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaycee-li @dandhlee @nayaknishant @sasha-gitg @rosiezou