Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass the PipelineJob credentials to create_gcs_bucket_for_pipeline_artifacts_if_it_does_not_exist #1537

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jul 22, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Jul 22, 2022
@sararob sararob self-requested a review July 22, 2022 19:49
Copy link
Contributor

@sararob sararob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Could you also add a unit test for cases when aiplatform.init is not called before calling PipelineJob.submit()?

google/cloud/aiplatform/pipeline_jobs.py Show resolved Hide resolved
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jul 22, 2022

Thanks for this! Could you also add a unit test for cases when aiplatform.init is not called before calling PipelineJob.submit()?

What is the behavior that such test would needs to check?

Note that unit tests are executed without accessing any real infrastructure (GCS or PipelineService).

…ate_gcs_bucket_for_pipeline_artifacts_if_it_does_not_exist
@sararob sararob merged commit b53e2b5 into googleapis:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants