-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Refactor schema classes to subclass from _Resource #1536
Merged
SinaChavoshi
merged 15 commits into
googleapis:main
from
SinaChavoshi:refactor_schema_classes_to_subclass_from_resouce
Jul 26, 2022
Merged
Feat: Refactor schema classes to subclass from _Resource #1536
SinaChavoshi
merged 15 commits into
googleapis:main
from
SinaChavoshi:refactor_schema_classes_to_subclass_from_resouce
Jul 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, Execution and Context
…sses_to_subclass_from_resouce
product-auto-label
bot
added
size: l
Pull request size is large.
api: vertex-ai
Issues related to the googleapis/python-aiplatform API.
labels
Jul 22, 2022
jialuzh
approved these changes
Jul 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Ark-kun
reviewed
Jul 22, 2022
dandhlee
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for samples.
jaycee-li
added a commit
that referenced
this pull request
Jul 27, 2022
…)" This reverts commit 93002e8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: vertex-ai
Issues related to the googleapis/python-aiplatform API.
size: l
Pull request size is large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat:Refactor schema classes to subclass from _Resource
This release feature changes the internal implementation of create method in Schema classes. The methods
Artifact.create_from_base_artifact_schema
andExecution.create_from_base_execution_schema
that were previously used by Schema classes are removed and the schema_base classes are now directly inheriting from the corresponding Artifact and Execution class.END_COMMIT_OVERRIDE
feat:Refactor schema classes to subclass from _Resource
END_COMMIT_OVERRIDE
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕