Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a way to easily clone a PipelineJob #1239

Merged
merged 17 commits into from
Jun 3, 2022

Conversation

jaycee-li
Copy link
Contributor

@jaycee-li jaycee-li requested a review from sasha-gitg May 17, 2022 22:07
@jaycee-li jaycee-li self-assigned this May 17, 2022
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels May 17, 2022
Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I only have a few small nits and suggestions.

google/cloud/aiplatform/pipeline_jobs.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/pipeline_jobs.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/pipeline_jobs.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/pipeline_jobs.py Show resolved Hide resolved
google/cloud/aiplatform/pipeline_jobs.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/pipeline_jobs.py Show resolved Hide resolved
@jaycee-li jaycee-li merged commit efaf6ed into googleapis:main Jun 3, 2022
rosiezou pushed a commit that referenced this pull request Jun 16, 2022
* Add batch_size kwarg for batch prediction jobs

* Fix errors

Update the copyright year. Change the order of the argument. Fix the syntax error.

* fix: change description layout

* feat: add clone method to PipelineJob

* fix: blacken and lint

* Update pipeline_jobs.py

* fix: update library names

* fix: formatting error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants