Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add update endpoint #1162

Merged
merged 10 commits into from
May 26, 2022
Merged

feat: add update endpoint #1162

merged 10 commits into from
May 26, 2022

Conversation

morgandu
Copy link
Contributor

@morgandu morgandu commented Apr 13, 2022 •
edited
Loading

  • add update endpoint
  • update unit tests
  • make sure all unit tests pass
  • make sure all system tests pass locally

Fixes b/227509107

blocked on b/227467389

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Apr 13, 2022
@morgandu morgandu marked this pull request as draft April 13, 2022 06:07
@sasha-gitg sasha-gitg added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Apr 20, 2022
@morgandu morgandu marked this pull request as ready for review April 22, 2022 17:20
sasha-gitg
sasha-gitg reviewed Apr 27, 2022
View reviewed changes
google/cloud/aiplatform/models.py Show resolved Hide resolved
google/cloud/aiplatform/models.py Outdated Show resolved Hide resolved
tests/unit/aiplatform/test_endpoints.py Show resolved Hide resolved
@morgandu morgandu marked this pull request as draft April 27, 2022 19:57
@product-auto-label product-auto-label bot added the api: vertex-ai Issues related to the googleapis/python-aiplatform API. label May 5, 2022
@sararob sararob added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 5, 2022
@samgoodman samgoodman marked this pull request as ready for review May 25, 2022 02:12
@samgoodman samgoodman merged commit 0ecfe1e into googleapis:main May 26, 2022
@release-please release-please bot mentioned this pull request May 26, 2022
Merged
@release-please release-please bot mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasha-gitg sasha-gitg sasha-gitg left review comments

@samgoodman samgoodman samgoodman approved these changes

Assignees
No one assigned
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@morgandu @samgoodman @sasha-gitg @sararob