Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add resource manager utils to get project ID from project number #1068

Merged
merged 4 commits into from
Mar 10, 2022
Merged

fix: add resource manager utils to get project ID from project number #1068

merged 4 commits into from
Mar 10, 2022

Conversation

morgandu
Copy link
Contributor

@morgandu morgandu commented Mar 9, 2022

  • added resource_manager_utils for converting project number to project id
  • updated project_id for featurestore df related method
  • added/updated unit tests
  • added setup package for google-cloud-resource-manager

Fixes #852, #943
b/216497263

@morgandu morgandu requested a review from a team as a code owner March 9, 2022 21:54
@morgandu morgandu requested a review from sasha-gitg March 9, 2022 21:54
@morgandu morgandu mentioned this pull request Mar 9, 2022
Merged
4 tasks
@kweinmeister kweinmeister added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 9, 2022
sasha-gitg
sasha-gitg approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@sasha-gitg sasha-gitg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

google/cloud/aiplatform/utils/resource_manager_utils.py Show resolved Hide resolved
@morgandu morgandu added the automerge Merge the pull request once unit tests and other checks pass. label Mar 10, 2022
@morgandu morgandu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 10, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 10, 2022
@morgandu morgandu merged commit f10a1d4 into googleapis:main Mar 10, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 10, 2022
@morgandu morgandu deleted the mor--fix-project-id branch March 10, 2022 19:02
@release-please release-please bot mentioned this pull request Mar 10, 2022
Merged
@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 11, 2022

Thank you for this fix.

However I'm not sure it fixes #852 and #943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasha-gitg sasha-gitg sasha-gitg approved these changes

@dizcology dizcology dizcology approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The SDK does not pick up the correct user project when running on Vertex Pipelines or CustomJobs
6 participants
@morgandu @Ark-kun @dizcology @sasha-gitg @kweinmeister @yoshi-kokoro