fix: loosen assertions for system test featurestore #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kweinmeister
approved these changes
Feb 27, 2022
morgandu
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
nayaknishant
approved these changes
Feb 28, 2022
ivanmkc
reviewed
Feb 28, 2022
| @@ -79,7 +76,7 @@ def test_create_get_list_featurestore(self, shared_state): | |||
| assert featurestore.resource_name == get_featurestore.resource_name | |||
|
|
|||
| list_featurestores = aiplatform.Featurestore.list() | |||
| assert (len(list_featurestores) - base_list_featurestores) == 1 | |||
| assert len(list_featurestores) >= 1 | |||
There was a problem hiding this comment.
For my system test, I actually do:
assert get_index.resource_name in [
index.resource_name for index in list_indexes
]
Just another option that doesn't depend on the absolute number of items in the list.
ivanmkc
reviewed
Feb 28, 2022
| @@ -121,7 +118,7 @@ def test_create_get_list_entity_types(self, shared_state): | |||
| list_entity_types = aiplatform.EntityType.list( | |||
| featurestore_name=featurestore_name | |||
| ) | |||
| assert len(list_entity_types) == 2 | |||
| assert len(list_entity_types) >= 1 | |||
ivanmkc
reviewed
Feb 28, 2022
| @@ -179,7 +173,7 @@ def test_create_get_list_features(self, shared_state): | |||
| ) | |||
|
|
|||
| list_user_features = user_entity_type.list_features() | |||
| assert len(list_user_features) == 3 | |||
| assert len(list_user_features) >= 1 | |||
morgandu
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
abcdefgs0324
pushed a commit
to abcdefgs0324/python-aiplatform
that referenced
this pull request
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1030