fix: Add support for Python 3.11 #329

hroncok · 2022-06-28T20:45:32Z

There are two changes:

Changes in the actual code:

_member_names changed from a list to a dict in bpo-45417: fix quadratic behaviour when creating an enum python/cpython#28907
- we instance-check and remove by list-specific or dict-specific way

Change in the tests only:

accessing other enum members via instance attributes is no longer possible
- we access them via the class instead
- we leave the original test in a try-except block

Some of the Python enum changes might get reverted,
see python/cpython#93910
But the fix is backwards compatible.

Fixes #326

google-cla · 2022-06-28T20:45:37Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

There are two changes: Changes in the actual code: - _member_names changed from a list to a dict in python/cpython#28907 - we instance-check and remove by list-specific or dict-specific way Change in the tests only: - accessing other enum members via instance attributes is no longer possible - we access them via the class instead - we leave the original test in a try-except block Some of the Python enum changes might get reverted, see python/cpython#93910 But the fix is backwards compatible. Fixes googleapis#326

hroncok · 2022-06-28T20:48:11Z

Some of your commit messages failed linting.

Feel free to reword that message however you see fit.

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

A link would be helpful for this.

ethanfurman · 2022-06-28T20:56:47Z

tests/test_enum_total_ordering.py

@@ -49,7 +49,11 @@ def test_total_ordering_w_other_enum_type():

    for item in enums_test.OtherEnum:
        assert not to_compare == item
-        assert to_compare.SOME_VALUE != item
+        assert type(to_compare).SOME_VALUE != item


to_compare is already OneEnum.SOME_VALUE -- so what is the purpose of the indirect reference through itself? Can this part of the test just be dropped?

Yeah, this entire assertion here seemed redundant to me as well, but I decided to keep testing what was tested.

Note that I am not available to fine-tune this into perfection, that's why I posted the patch in a comment initially as "this makes it pass" instead of opening a PR right away.

parthea · 2022-06-29T14:58:30Z

Thanks @hroncok! Please could you sign the CLA using the link below?

📝 If you are not currently covered under a CLA, please visit https://cla.developers.google.com/.

hroncok · 2022-06-29T15:02:56Z

I'm pretty sure I've already once approved this as being part of Red Hat, but now I also signed as an individual.

conventional-commit-lint-gcf · 2022-06-29T19:39:55Z

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

parthea · 2022-06-29T19:45:06Z

The github actions checks appear to be stuck with Waiting for status to be reported. I'm going to try closing the PR and re-opening it.

parthea · 2022-06-29T19:50:52Z

LGTM but let's wait for #327 to be merged so that checks are passing.

parthea · 2022-07-02T16:24:19Z

I'm going to try adding python 3.11.0-beta.3 to the tests to see if I can get the coverage check to pass

parthea · 2023-01-05T23:08:32Z

~~The github actions tests appear to be stuck. Closing and re-opening the PR didn't help. I'll try again tomorrow.~~

The github action failed to start due to a syntax error. It should be fixed now

hroncok requested review from a team as code owners June 28, 2022 20:45

hroncok force-pushed the python3.11 branch from 168bf60 to 468c93e Compare June 28, 2022 20:45

hroncok mentioned this pull request Jun 28, 2022

Test failures in Python 3.11.0b3 #326

Closed

ethanfurman reviewed Jun 28, 2022

View reviewed changes

parthea changed the title ~~Adjust to enum changes in Python 3.11.0b3~~ fix: Adjust to enum changes to support Python 3.11.0b3 Jun 29, 2022

parthea changed the title ~~fix: Adjust to enum changes to support Python 3.11.0b3~~ fix: Adjust enum to support Python 3.11.0b3 Jun 29, 2022

parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 29, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 29, 2022

parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 29, 2022

parthea closed this Jun 29, 2022

parthea reopened this Jun 29, 2022

parthea approved these changes Jun 29, 2022

View reviewed changes

Merge branch 'main' into python3.11

b337126

ci: unit test session with python 3.11.0-beta.3

b201662

parthea closed this Jul 2, 2022

parthea reopened this Jul 2, 2022

ci: add python v3.11.0-beta.3 to noxfile.py

c7371b4

parthea closed this Jul 2, 2022

parthea reopened this Jul 2, 2022

parthea self-assigned this Jan 5, 2023

parthea changed the title ~~fix: Adjust enum to support Python 3.11.0b3~~ fix: Adjust enum to support Python 3.11 Jan 5, 2023

fix ci

20acd08

parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 5, 2023

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 5, 2023

parthea added 4 commits January 5, 2023 22:46

mark python 3.11 tests as required

f635f9c

add python 3.11 to setup.py

a1331bb

fix docs build

1728f48

remove python 3.11 test for unitcpp

880a952

parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 5, 2023

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 5, 2023

parthea changed the title ~~fix: Adjust enum to support Python 3.11~~ fix: Add support for Python 3.11 Jan 5, 2023

remove python 3.11 test for unitcpp

85b92fe

parthea closed this Jan 5, 2023

parthea reopened this Jan 5, 2023

parthea closed this Jan 5, 2023

parthea reopened this Jan 5, 2023

parthea closed this Jan 5, 2023

parthea reopened this Jan 5, 2023

remove python 3.11 test for unitcpp

2b25b4f

parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 5, 2023

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 5, 2023

attempt to fix exclude in github action

8ee3eed

parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 5, 2023

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 5, 2023

parthea merged commit 5cff3a0 into googleapis:main Jan 5, 2023

This was referenced Jan 5, 2023

chore(main): release 1.22.2 #343

Merged

chore(main): release 1.22.2 #346

Closed

parthea mentioned this pull request Jul 9, 2024

proto-plus enums fail in conda environments #469

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Add support for Python 3.11 #329

fix: Add support for Python 3.11 #329

hroncok commented Jun 28, 2022 •

edited

Loading

google-cla bot commented Jun 28, 2022

hroncok commented Jun 28, 2022

ethanfurman Jun 28, 2022

hroncok Jun 28, 2022

parthea commented Jun 29, 2022

hroncok commented Jun 29, 2022

conventional-commit-lint-gcf bot commented Jun 29, 2022 •

edited

Loading

parthea commented Jun 29, 2022

parthea commented Jun 29, 2022

parthea commented Jul 2, 2022

parthea commented Jan 5, 2023 •

edited

Loading

fix: Add support for Python 3.11 #329

fix: Add support for Python 3.11 #329

Conversation

hroncok commented Jun 28, 2022 • edited Loading

google-cla bot commented Jun 28, 2022

hroncok commented Jun 28, 2022

ethanfurman Jun 28, 2022

Choose a reason for hiding this comment

hroncok Jun 28, 2022

Choose a reason for hiding this comment

parthea commented Jun 29, 2022

hroncok commented Jun 29, 2022

conventional-commit-lint-gcf bot commented Jun 29, 2022 • edited Loading

parthea commented Jun 29, 2022

parthea commented Jun 29, 2022

parthea commented Jul 2, 2022

parthea commented Jan 5, 2023 • edited Loading

hroncok commented Jun 28, 2022 •

edited

Loading

conventional-commit-lint-gcf bot commented Jun 29, 2022 •

edited

Loading

parthea commented Jan 5, 2023 •

edited

Loading