Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proto-plus introduces substantial overhead to interactions with pb. #222

Closed
crwilcox opened this issue Mar 22, 2021 · 2 comments
Closed

proto-plus introduces substantial overhead to interactions with pb. #222

crwilcox opened this issue Mar 22, 2021 · 2 comments
Assignees
@craiglabenz
Labels
P2 A nice-to-fix bug priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@crwilcox
Copy link
Contributor

Profiled/Verified: googleapis/python-pubsub#158

Suspected: googleapis/python-datastore#145

It seems that the use of proto-plus is introducing somewhere between 40-150% overhead to client libraries when using proto plus.
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Mar 23, 2021
@software-dov software-dov added P2 A nice-to-fix bug priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Mar 30, 2021
@GabrieleMazzola GabrieleMazzola mentioned this issue Apr 10, 2021
Closed
@tseaver
Copy link
Contributor

tseaver commented Apr 14, 2021

Today I measured an order of magnitude slowdown for datastore (unmarshaling query results to entities).

@craiglabenz craiglabenz mentioned this issue May 4, 2021
Closed
@craiglabenz craiglabenz self-assigned this May 10, 2021
@craiglabenz
Copy link

Closing this, as the state of proto-plus performance optimizations is known to center around changing lines of code like this:

my_proto_plus_object.some_attribute

into this:

my_proto_plus_object._pb.some_attribute

to reclaim >= 90% of the lost performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@craiglabenz craiglabenz

Labels
P2 A nice-to-fix bug priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Protobuf Performance Refactor googleapis/proto-plus-python
5 participants
@tseaver @crwilcox @craiglabenz @software-dov @yoshi-automation