Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: support node.js 10 and up #67

Merged
merged 1 commit into from
Feb 6, 2020
Merged

fix!: support node.js 10 and up #67

merged 1 commit into from
Feb 6, 2020

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Feb 5, 2020 •
edited
Loading

BREAKING CHANGE: This change drops explicit support for node.js 8.x, and below. Please upgrade to an LTS supported version :)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 5, 2020
@JustinBeckwith JustinBeckwith requested a review from bcoe February 5, 2020 20:48
bcoe
bcoe approved these changes Feb 5, 2020
View reviewed changes
Copy link

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a thought, could we just switch this to GitHub actions? instead of having yet another CI/CD in the mix?

@JustinBeckwith JustinBeckwith merged commit 06ed421 into master Feb 6, 2020
@release-please release-please bot mentioned this pull request Feb 6, 2020
Closed
@release-please release-please bot mentioned this pull request Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JustinBeckwith @bcoe @googlebot