Skip to content
This repository has been archived by the owner on Nov 5, 2019. It is now read-only.

Add timeout argument to transport.request #618

Closed
dhermes opened this issue Aug 11, 2016 · 2 comments
Closed

Add timeout argument to transport.request #618

dhermes opened this issue Aug 11, 2016 · 2 comments
Milestone

Comments

@dhermes
Copy link
Contributor

dhermes commented Aug 11, 2016

See #612 (comment)

It's unclear if an httplib2.Http request can be made with a timeout if the instance wasn't created with one, though likely it could be fixed with

orig_timeout = http.timeout
try:
    http.timeout = temp_value
    do_stuff(http)
finally:
    http.timeout = orig_timeout

More problematic is when http.request has been modified (by our wrappers) and we are unsure what has been passed to transport.request (though I have an idea there).

@theacodes
Copy link
Contributor

Depending on the decision in #128 we could have the guarantee that request hasn't been modified by our wrapper.

@theacodes theacodes modified the milestone: 4.0.0 Sep 13, 2016
@theacodes
Copy link
Contributor

Thank you for creating this issue, however, this project is deprecatedand we will only be addressing critical security issues. You can read moreabout this deprecation here.

If you need support or help using this library, we recommend that you ask yourquestion on StackOverflow.

If you still think this issue is relevant and should be addressed, pleasecomment and let us know!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants