fix: Remove pumpify
#2029
Merged
fix: Remove pumpify
#2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
shaffeeullah
approved these changes
Aug 12, 2022
There was a problem hiding this comment.
one small nit, but otherwise looks good! please wait for @ddelgrosso1 to take a look as well. thanks for doing this!!
|
Overall nothing stands out to me as troublesome. Perhaps we should move this to a fix and/or feature. We have handled quite a few things during this fixit week and it might be nice to do a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1915 🦕
As a follow-up, we should remove
duplexify, which is a breaking change as it is exposed as a return type in a few places. In many places, aTransformstream makes more sense and is much cleaner.