Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 5.20.0 is broken #1931

Closed
segevfiner opened this issue May 16, 2022 · 2 comments · Fixed by #1932
Closed

Release 5.20.0 is broken #1931

segevfiner opened this issue May 16, 2022 · 2 comments · Fixed by #1932
Assignees
@ddelgrosso1
Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@segevfiner
Copy link

segevfiner commented May 16, 2022 •
edited
Loading

Environment details

  • OS: macOS 12.3.1
  • Node.js version: 16.15.0
  • npm version: 8.10.0
  • @google-cloud/storage version: 5.20.0

Steps to reproduce

  1. Download https://registry.npmjs.org/@google-cloud/storage/-/storage-5.20.0.tgz
  2. There is no JS code in the file...
Cannot find module '@google-cloud/storage' or its corresponding type declarations.
@segevfiner segevfiner added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 16, 2022
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label May 16, 2022
@ddelgrosso1 ddelgrosso1 self-assigned this May 16, 2022
@ddelgrosso1 ddelgrosso1 mentioned this issue May 16, 2022
Merged
4 tasks
@mcarriere
Copy link

same issue here

@ddelgrosso1 ddelgrosso1 added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 16, 2022
@ddelgrosso1
Copy link
Contributor

@segevfiner this should be resolved by v5.20.1. If you are still seeing issues with 5.20.1 please reopen this issue and I will investigate further.

@ddelgrosso1 ddelgrosso1 mentioned this issue May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddelgrosso1 ddelgrosso1

Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not use import on package.json ddelgrosso1/nodejs-storage
3 participants
@segevfiner @mcarriere @ddelgrosso1