Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage uniform bucket-level access preserves bucket/file ACL over uniform bucket-level access on/off: should preserve file ACL failed #1844

Closed
flaky-bot bot opened this issue Apr 6, 2022 · 4 comments · Fixed by #1848
Assignees
Labels
api: storage Issues related to the googleapis/nodejs-storage API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Apr 6, 2022

This test failed!

To configure my behavior, see the Flaky Bot documentation.

If I'm commenting on this issue too often, add the flakybot: quiet label and
I will stop commenting.


commit: 91fe5ed
buildURL: Build Status, Sponge
status: failed

Test output
Cannot get legacy ACL for an object when uniform bucket-level access is enabled. Read more at https://cloud.google.com/storage/docs/uniform-bucket-level-access
Error: Cannot get legacy ACL for an object when uniform bucket-level access is enabled. Read more at https://cloud.google.com/storage/docs/uniform-bucket-level-access
    at new ApiError (build/src/nodejs-common/util.js:76:15)
        -> /workspace/src/nodejs-common/util.ts:262:11
    at Util.parseHttpRespBody (build/src/nodejs-common/util.js:211:38)
        -> /workspace/src/nodejs-common/util.ts:463:32
    at Util.handleResp (build/src/nodejs-common/util.js:152:117)
        -> /workspace/src/nodejs-common/util.ts:396:20
    at /workspace/build/src/nodejs-common/util.js:496:22
        -> /workspace/src/nodejs-common/util.ts:826:16
    at onResponse (node_modules/retry-request/index.js:228:7)
    at /workspace/node_modules/teeny-request/build/src/index.js:226:13
        -> /workspace/node_modules/teeny-request/src/index.ts:333:11
    at runMicrotasks ()
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 6, 2022
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Apr 6, 2022
@flaky-bot
Copy link
Author

flaky-bot bot commented Apr 6, 2022

commit: caf7ee5
buildURL: Build Status, Sponge
status: failed

Test output
Cannot get legacy ACL for an object when uniform bucket-level access is enabled. Read more at https://cloud.google.com/storage/docs/uniform-bucket-level-access
Error: Cannot get legacy ACL for an object when uniform bucket-level access is enabled. Read more at https://cloud.google.com/storage/docs/uniform-bucket-level-access
    at new ApiError (build/src/nodejs-common/util.js:76:15)
        -> /workspace/src/nodejs-common/util.ts:262:11
    at Util.parseHttpRespBody (build/src/nodejs-common/util.js:211:38)
        -> /workspace/src/nodejs-common/util.ts:463:32
    at Util.handleResp (build/src/nodejs-common/util.js:152:117)
        -> /workspace/src/nodejs-common/util.ts:396:20
    at /workspace/build/src/nodejs-common/util.js:496:22
        -> /workspace/src/nodejs-common/util.ts:826:16
    at onResponse (node_modules/retry-request/index.js:228:7)
    at /workspace/node_modules/teeny-request/build/src/index.js:226:13
        -> /workspace/node_modules/teeny-request/src/index.ts:333:11
    at runMicrotasks ()
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

@flaky-bot
Copy link
Author

flaky-bot bot commented Apr 6, 2022

Test passed for commit 66d5b57 (Build Status, Sponge)! Closing this issue.

@flaky-bot
Copy link
Author

flaky-bot bot commented Apr 8, 2022

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


commit: 638a47b
buildURL: Build Status, Sponge
status: failed

Test output
Cannot get legacy ACL for an object when uniform bucket-level access is enabled. Read more at https://cloud.google.com/storage/docs/uniform-bucket-level-access
Error: Cannot get legacy ACL for an object when uniform bucket-level access is enabled. Read more at https://cloud.google.com/storage/docs/uniform-bucket-level-access
    at new ApiError (build/src/nodejs-common/util.js:76:15)
        -> /workspace/src/nodejs-common/util.ts:262:11
    at Util.parseHttpRespBody (build/src/nodejs-common/util.js:211:38)
        -> /workspace/src/nodejs-common/util.ts:463:32
    at Util.handleResp (build/src/nodejs-common/util.js:152:117)
        -> /workspace/src/nodejs-common/util.ts:396:20
    at /workspace/build/src/nodejs-common/util.js:496:22
        -> /workspace/src/nodejs-common/util.ts:826:16
    at onResponse (node_modules/retry-request/index.js:228:7)
    at /workspace/node_modules/teeny-request/build/src/index.js:226:13
        -> /workspace/node_modules/teeny-request/src/index.ts:333:11
    at runMicrotasks ()
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Apr 8, 2022
@ddelgrosso1 ddelgrosso1 self-assigned this Apr 12, 2022
@ddelgrosso1
Copy link
Contributor

I made a fix that should resolve this issue. The issue appears to be caused by a failed resumable upload that then caches an old URL without the added query params. In order to alleviate the issue I made the file names more unique. I am going to close this issue. If it resurfaces I will add the additional step of manually clearing the cache between tests that utilize resumable uploads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant