Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: encode name portion when calling publicUrl function #1828

Merged
merged 2 commits into from
Mar 28, 2022
Merged

fix: encode name portion when calling publicUrl function #1828

merged 2 commits into from
Mar 28, 2022

Conversation

ddelgrosso1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1824 🦕

@ddelgrosso1 ddelgrosso1 requested review from a team as code owners March 28, 2022 15:02
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Mar 28, 2022
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 28, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 28, 2022
@shaffeeullah shaffeeullah merged commit 5522b35 into googleapis:main Mar 28, 2022
@release-please release-please bot mentioned this pull request Mar 28, 2022
Merged
@ddelgrosso1 ddelgrosso1 deleted the fix-public-url branch March 28, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaffeeullah shaffeeullah shaffeeullah approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File.publicUrl() returns an incorrect URL if the file key contains URL query parameters
2 participants
@ddelgrosso1 @shaffeeullah